With that being said, I need a list of volunteers that would be willing to start working on the high priority known bugs that are currently within Svof. I believe @Shirszae, @Klendathu and @Cooper all mentioned that if this was changed, they would be happy to contribute. The list of known issues lives here: https://github.com/svof/svof/issues
I will hold to my word and contribute to a credit pool (hopefully with others that also use Svof) so people are getting something out of helping the community!
I'm standing by what i said before, I'm going to involve myself in things. I said I would with the crowdmap and mapping script, and I said I would with Svof
Tharos, the Announcer of Delos shouts, "It's near the end of the egghunt and I still haven't figured out how to pronounce Clean-dat-hoo."
Okay, as promised here's a version to test. Ihighly recommend using a separate profile for this, as I have not done much testing on this and every single part of the system was changed.
When you test something, comment on that link that it works OK.
Addons are not present in this beta yet, this is the core
Installing
The whole point of this exersize is to make the system easier to work on so you guys can all keep it up up to date. Given this, the install process has changed to make it easier to contribute your changes to the master copy at https://github.com/svof/svof. It is now the following:
2) Unzip it somewhere permanent. Don't delete the unzipped files.
3) Install svo (install me in module manager).xml in the Module Manager:
4) Tick sync for all modules.
5) Done. Don't delete the unzipped files - that's where the system is always loaded from now.
Oh and the vconfig releasechannel testing won't work for updating to this test version unlike what we said above - given the package/module change, it won't work right now.
Reporting bugs
Not in this thread, it'll get confusing fast. Report them to https://github.com/svof/svof/issues please for this beta and in the future too.
Submitting improvements
If this is a trivial improvement, you're a sloppy coder, or whatever - all improvements are welcome. You guys have gotta keep the system updated now.
If you're new to using Github:
1) Save your profile - this will update the xml file on your computer.
A) At least 3.6.0 which has the autoupdater - this'll allow the system to make use of the latest features in Mudlet as they come.
Q) This is installed as a module with sync, does this mean all profiles will get it?
A) Sync does 2 things 1) sync modules across all other profiles, if the module is also installed in another profile 2) updated the .xml file on your computer. Sync is just used here for the 2nd feature of it, and Svof will not get automatically installed across all your profiles.
Automatic update doesn't work yet, so you'll need to manually uninstall the old modules and install the new one. This should fix a "svo.addaff" error as well as Dragonform in/out errors.
Anyone doing testing on the in-client-svof, a workaround for the parry issues is to copy your sp_config file over from one profile to the other. (It is located from the mudlet folder: ..profiles/(profile name)/svo/config/sp_config)
If you're testing the beta in client Svof, and you come across an issue please file an issue on the github. In addition, please give as much information as possible. Tell us what's happening, what commands you used right before it started happening, what errors both SVOF and Mudlet are telling you, etc.
Dunn tells you, "I hate you." (Party): You say, "Bad plan coming right up."
Thanks to the people who've been testing the list reporting things on github! Once the list is complete and there's new migration bugs found, this new in-client version w/ multiclass support will be out.
This beta also includes a selection of the addons including peopletracker @Zykatious
Tested: - Serpent class switch defup and keepup looks okay to me - Runewarden class switch defup and keepup looks okay to me - Bard class switch defup and keepup looks okay to me
Problems: - Shows me this when I class switch: https://ada-young.appspot.com/pastebin/wAdYCXTp - Monk > Shikudo, kept trying to send "guard" - Health or mana changes show up before prompt, whereas previously it was after prompt - Depthswalker defup and keepup doesn't seem to be working correctly. It doesn't defup the stuffs I want it to defup. - existing custom prompt doesn't carry over to the new SVOF
I don't have github and doesn't know how to use that, so I posted it here... or if there's other options. Will test more when I have more time.Thanks.
Thanks for testing! I'll have a look at this feedback.
You can sign up on Github for free, and commenting is rather obvious - I recommend to do it as it's the single way to keep issues organised. If it's not on github, issues might as well be unknown because having them scattered all over will just make it difficult for people who'll take up updating on Svof
Fixes the issue with some spam on enabling serverside and other things. Only known issue in beta right now is aeon/ret curing sometimes spams and changing classes or dragonform in/out a lot repeats the 'system save' and other echoes.
@Vadimuses@Atalkez if you dont have it by the time i get home I redid svos list and imported it to my profile a few days ago. Ill send you the file marked 'current' as well. Not sure how gpod it is but it works for me as far as static prios go
for water lord if you open the svo file in notepad++ (it's in the .config/mudlet/profiles/<name of your profile> folder for windows)
search for -- Dragoncraft: everyone gets it, then you can add this in after that block
<div>-- Elemental Lord
<br></div><div>defs_data:set("ElementalLord", { type = "Elemental",</div><div> offline_defence = true,</div><div> invisibledef = true,</div><div> stays_on_death = true,</div><div> on = {"With a cursory thought, you still your clamorous heart and arise whole, gazing out from within your titanic waters. All around you, above and below, life surges. Every pulse and beat, you feel as your own. By the will of Sllshya, Water is yours to command!","Your elemental might has already overtaken your form."},</div><div> off = "Primal water abandons you, your flawed physicality reasserting itself once more as you forsake your primordial form." })</div><div> defs_data:set("cohesion", { type = "Elemental",</div><div> specialskip = function() return not defc.ElementalLord end,</div><div> def = "You have altered the cohesion of your form.",</div><div> on = {"You alter the cohesion of your fluid form.", "You have already altered the cohesiveness of your form."}})</div>
then search for defences.lost("dragonarmour") and after the
<div>cohesion = {</div><div> physical = {</div><div> balanceful_act = true,</div><div> aspriority = 0,</div><div> spriority = 0,</div><div> def = true,</div><div><br></div><div> isadvisable = function ()</div><div> return (((sys.deffing and defdefup[defs.mode].cohesion and not defc.cohesion) or (conf.keepup and defkeepup[defs.mode].cohesion and not defc.cohesion)) and not codepaste.balanceful_defs_codepaste() and defc.ElementalLord) or false</div><div> end,</div><div><br></div><div> oncompleted = function ()</div><div> defences.got("cohesion")</div><div> end,</div><div><br></div><div> action = "manifest cohesion",</div><div> onstart = function ()</div><div> send("manifest cohesion", conf.commandecho)</div><div> end</div><div> },</div><div> gone = {</div><div> oncompleted = function()</div><div> defences.lost("cohesion")</div><div> end</div><div> }</div><div> }</div>
after that find me.skills and insert after your class skills
</code> Elemental = true</pre><br><br>mine looks like this due to also being an alchemist<br><br><div></div><pre class="CodeBlock"><code><div>me.skills = {</div><div> elementalism = true,</div><div> crystalism = true,</div><div> artificing = true,</div><div> physiology = true,</div><div> transmutation = true,</div><div> alchemy = true,</div><div> Elemental = true</div><div>}</div>
I also got in mudlet itself a script that does
if gmcp.Char.Status.race == "Elemental Lord" then svo.defc.ElementalLord = true else svo.defc.ElementalLord = false end
That'll make you able to add 'cohesion' to a defup method and have it show in DEF (along with Elemental Lord as Dragons do), it's not as fancy as the Dragon one cause I haven't entirely figured out how that was done yet
It also doesn't do squat for curing, it just makes you able to def up easier via vdefs <mode>
I've tried this a few times now, but it keeps having an unexpected and critical failure result. I get a similar fault if I use gem of reincarnation after I died in dragonform, but then re-entering dragonform fixes it. For some reason the svo. structure seems to fail and none of the svo functions work anymore. I've edited the "svo" notepad, restarted mudlet and then the problems begin.. First my custom prompt disappears and I get "attempt to call a nil value" spammed on my screen. Svo functions like vconfig, vshow doesn't work anymore. vlua svo works, vlua svo.bals does not work.
See logs for behavior and errors.. Any idea what might be the problem?
Ok. doesn't work very well. Something's missing. vshow defup and vshow keepup turns up empty, vconfig2 has lost "custom prompt" for example and custom prompt is no longer showing. It's like it doesn't know which class/race it is anymore.
I'm using the svo allclasses ahmet made a while back btw.
If you want to add a new def, you have to add it to the def table and the dictionary. It looks like you added it to the def table, but not the dictionary, which contains defup logic.
Based on the way Veldrin implemented his Elemental form, your def table addition should look something like this:
<div> defs_data:set("fireshroud", { type = "Elemental",</div><div>
specialskip = function() return not defc.ElementalLord end, // Note this should be ElementalLord, not dragonform</div><div>
def = "You have shrouded youself with flame.",</div><div>
on = "A shroud of flame bursts into being, cloaking you in a burning aura of crimson."})</div>
Your dict addition should look something like this:
Finally, you can add it to the sstosvoa table, which contains the way it appears in GMCP. If GMCP called fireshroud, "fireveil" or something, it would look like this:
Comments
Edit: You can switch svof release branches with "vconfig releasechannel <testing|stable>".
GMCP documentation: https://github.com/keneanung/GMCPAdditions
svof github site: https://github.com/svof/svof and documentation at https://svof.github.io/svof
Svof
Mudlet Discord join up
With that being said, I need a list of volunteers that would be willing to start working on the high priority known bugs that are currently within Svof. I believe @Shirszae, @Klendathu and @Cooper all mentioned that if this was changed, they would be happy to contribute. The list of known issues lives here: https://github.com/svof/svof/issues
I will hold to my word and contribute to a credit pool (hopefully with others that also use Svof) so people are getting something out of helping the community!
And you won't understand the cause of your grief...
...But you'll always follow the voices beneath.
Dunn tells you, "I hate you."
(Party): You say, "Bad plan coming right up."
What to test?
Everything, need to check this list off: https://github.com/svof/svof/pull/329
When you test something, comment on that link that it works OK.
Addons are not present in this beta yet, this is the core
Installing
The whole point of this exersize is to make the system easier to work on so you guys can all keep it up up to date. Given this, the install process has changed to make it easier to contribute your changes to the master copy at https://github.com/svof/svof. It is now the following:1) Download the zip.
2) Unzip it somewhere permanent. Don't delete the unzipped files.
3) Install svo (install me in module manager).xml in the Module Manager:
4) Tick sync for all modules.
5) Done. Don't delete the unzipped files - that's where the system is always loaded from now.
Oh and the vconfig releasechannel testing won't work for updating to this test version unlike what we said above - given the package/module change, it won't work right now.
Reporting bugs
Not in this thread, it'll get confusing fast. Report them to https://github.com/svof/svof/issues please for this beta and in the future too.
Submitting improvements
If this is a trivial improvement, you're a sloppy coder, or whatever - all improvements are welcome. You guys have gotta keep the system updated now.If you're new to using Github:
1) Save your profile - this will update the xml file on your computer.
2) Go to https://github.com/svof/svof/tree/in-client-svof, find the .xml file you wanna update, and click edit:
3) Follow the big green buttons to commit your change and then submit a pull request:
4) Done.
Svof
Mudlet Discord join up
Q) What Mudlet version is required?
A) At least 3.6.0 which has the autoupdater - this'll allow the system to make use of the latest features in Mudlet as they come.
Q) This is installed as a module with sync, does this mean all profiles will get it?
A) Sync does 2 things 1) sync modules across all other profiles, if the module is also installed in another profile 2) updated the .xml file on your computer. Sync is just used here for the 2nd feature of it, and Svof will not get automatically installed across all your profiles.
Svof
Mudlet Discord join up
Automatic update doesn't work yet, so you'll need to manually uninstall the old modules and install the new one. This should fix a "svo.addaff" error as well as Dragonform in/out errors.
Still need people to test and check off items at https://github.com/svof/svof/pull/329!
If you've got questions about any code, now that it's all in Mudlet, feel free to ask as well.
Svof
Mudlet Discord join up
Dunn tells you, "I hate you."
(Party): You say, "Bad plan coming right up."
Thanks to the people who've been testing the list reporting things on github! Once the list is complete and there's new migration bugs found, this new in-client version w/ multiclass support will be out.
This beta also includes a selection of the addons including peopletracker @Zykatious
Svof
Mudlet Discord join up
- Serpent class switch defup and keepup looks okay to me
- Runewarden class switch defup and keepup looks okay to me
- Bard class switch defup and keepup looks okay to me
Problems:
- Shows me this when I class switch: https://ada-young.appspot.com/pastebin/wAdYCXTp
- Monk > Shikudo, kept trying to send "guard"
- Health or mana changes show up before prompt, whereas previously it was after prompt
- Depthswalker defup and keepup doesn't seem to be working correctly. It doesn't defup the stuffs I want it to defup.
- existing custom prompt doesn't carry over to the new SVOF
I don't have github and doesn't know how to use that, so I posted it here... or if there's other options. Will test more when I have more time.Thanks.
You can sign up on Github for free, and commenting is rather obvious - I recommend to do it as it's the single way to keep issues organised. If it's not on github, issues might as well be unknown because having them scattered all over will just make it difficult for people who'll take up updating on Svof
Svof
Mudlet Discord join up
Fixes the issue with some spam on enabling serverside and other things. Only known issue in beta right now is aeon/ret curing sometimes spams and changing classes or dragonform in/out a lot repeats the 'system save' and other echoes.
Svof
Mudlet Discord join up
Svof
Mudlet Discord join up
Penwize has cowardly forfeited the challenge to mortal combat issued by Atalkez.
Svof
Mudlet Discord join up
See logs for behavior and errors.. Any idea what might be the problem?
https://ada-young.appspot.com/pastebin/LQZ63ef3
https://ada-young.appspot.com/pastebin/L7D7XZzn
I removed this and it started working again. Why it hate my fireshroud defence?
I'm using the svo allclasses ahmet made a while back btw.
It looks like you added it to the def table, but not the dictionary, which contains defup logic.
Based on the way Veldrin implemented his Elemental form, your def table addition should look something like this:
Your dict addition should look something like this:
Finally, you can add it to the sstosvoa table, which contains the way it appears in GMCP. If GMCP called fireshroud, "fireveil" or something, it would look like this:
Adding a new aff would be more complex. I'm not sure if it's doable by directly modifying the svo file, but details can be found here: https://github.com/svof/svof/blob/master/Developer readme.md
Thankfully, with the new changes, you no longer have to dig through raw files, but the gist of how to add defs/affs should be the same.