All class BattleRage tracker [Mudlet]

Rangor

Does this alert you when a friend does a "combo-able" attack on the same target you're already hitting? Or something similar to that.

Klendathu

Rangor said:

Does this alert you when a friend does a "combo-able" attack on the same target you're already hitting? Or something similar to that.

Nope. Something for future development, would need third-party triggers, and having enough problems getting first person triggers!

An event is raised when you put an affliction on a denizen, so you can relay it to your party - rageGUI denizen gained aff.

I've included an example event handler script in the Battlerage event handler script block.

Crono

Anyone else have an issue with the timer?  When I updated it no longer showed the time left until I could use an ability again.

Klendathu

Crono said:

Anyone else have an issue with the timer?  When I updated it no longer showed the time left until I could use an ability again.

Is that after restarting Mudlet too? (You shouldn't have to restart Mudlet, but it can't hurt!)

Crono

Yeah, I have restarted mudlet and reinstalled.  Still same issue.  Timer is not working.

Klendathu

UPDATE to 1.1     Download

Sorry for the delay on the update, work has been insaaaaaaaanely busy.

• recklessness duration increased to 15 seconds (might be too long)
• battlerage fade increased to 15 seconds
• various typo and bug-fixes

Klendathu

UPDATE to 1.2    Download

• added horrify and crack (priest) lines (thanks @Silas)
• added sentinel lines (thanks @Praxides)

Argathian

I am having a problem with the runewarden timers. When I use etch, it puts onslaught on timer, and using onslaught puts bulwark on timer. I've had a look at the script but I suck at coding so I can't figure out how to change it.

Noak

Awesome script!

Elon

Argathian said:

I am having a problem with the runewarden timers. When I use etch, it puts onslaught on timer, and using onslaught puts bulwark on timer. I've had a look at the script but I suck at coding so I can't figure out how to change it.

Having the same issue as a Paladin.. But it is only when I'm using Keneanung's bashing script. If I manually battlerage, the timers work fine. Any ideas @Keneanung?

Elon

If I had to take a stab at whats going on, the same GMCP/or some sort of timer @Klendathu uses to track 'Shock' and 'Harrow' for the timers, must be getting used by Keneanung's bashing script somewhere to track what it needs to track for using rage? Just a guess.

Keneanung

Elon said:

Argathian said:

I am having a problem with the runewarden timers. When I use etch, it puts onslaught on timer, and using onslaught puts bulwark on timer. I've had a look at the script but I suck at coding so I can't figure out how to change it.

Having the same issue as a Paladin.. But it is only when I'm using Keneanung's bashing script. If I manually battlerage, the timers work fine. Any ideas @Keneanung?

Hrm, are you sure the script uses the correct battlerage attacks? I have no Paladin/Knight to test anything with them. To not further derail this thread, could you send me the answer in messages?

Elon said:

If I had to take a stab at whats going on, the same GMCP/or some sort of timer @Klendathu uses to track 'Shock' and 'Harrow' for the timers, must be getting used by Keneanung's bashing script somewhere to track what it needs to track for using rage? Just a guess.

Nope, the ragetracker uses almost exclusively triggers while my script uses GMCP only and there are no parts used by both as far as I am aware.

Klendathu

My rage tracker reuses the same code for all classes, using generic names for the timers, etc. If it were wrong for one class, it'd be wrong for all classes. I'll have a rummage around in the code and see if there's something squiffy.

Praxides

Klendathu said:

My rage tracker reuses the same code for all classes, using generic names for the timers, etc. If it were wrong for one class, it'd be wrong for all classes. I'll have a rummage around in the code and see if there's something squiffy.

I think what I did to fix them was in the triggers for the Runie abilities, some of them were switched when referenced to the rage table.

local tbl = rageGUI.rageTable[#]
rageGUI.rageTimer("timerRage#,tbl[1]:title(),tbl[2],rage#)

Where the '#' in the above was incorrectly pointing to Onslaught's number (4) in Etch and so on.

Klendathu

Could be that the data table is out of date.

Here's the abilities for Runie and Pally, could you validate they're in the correct order?

Runewarden:

1. Collide
2. Bullwark
3. Fragment
4. Onslaught
5. Etch
6. Safeguard

Paladin:

1. Harrow
2. Regeneration
3. Faithrend
4. Shock
5. Punishment
6. Recovery

Noak

Oops wrong thread.

Keneanung

@KlendathuI found out why it was counting the 4th ability for Paladin's first. You have the wrong trigger line there. Using the Priest 4 line in Paladin 1st (both are named harrow by the way) worked. But I don't know at all if the trigger line for Priest 4 harrow is correct.

Here is what I picked up while going through some others in theory:
- Occultist 6 is off: it gives "rageTimer5" as 1st argument instead of "rageTimer6" to rageGUI.rageTimer()
- Some trigger names are off abou the position (no functional bugs though)

Klendathu

Thanks, I'll amend my local copy and release an update soon, just trying to find a clean way to show / hide the entire GUI (it brings windows back in a horrible way, back to front)

Keneanung

I did some more fiddling with this, because people suggested it worked when manualling paladin. The harrow line for Paladin 1 is correct, if you use HARROW as it is in the AB files. The GMCP answer is possibly the AB file of the priest version of harrow (as it costs 36 rage in that answer) and this is where the tracker gets the command from.

But this is where the fun begins: If I use the command that is sent via gmcp as a paladin, it works too, is a DoT and gives the priest line. But it costs only 14 rage... I submitted a bug in game for that.

Klendathu

My tracker uses the commands as specified in the AB files, and sends them using send, rather than via GMCP. I think, therefore, that the Harrow part is correct in the tracker, but there's no harm in having the second trigger in there too.

I should really download and install your script so I can rip it off look at how you've done things and get inspiration 

Keneanung

The commands are sent via send as well. Only battlerage skill details are requested via gmcp (see https://github.com/keneanung/GMCPAdditions/blob/master/README.md#charskills)

Antonius

Keneanung said:

I did some more fiddling with this, because people suggested it worked when manualling paladin. The harrow line for Paladin 1 is correct, if you use HARROW as it is in the AB files. The GMCP answer is possibly the AB file of the priest version of harrow (as it costs 36 rage in that answer) and this is where the tracker gets the command from.

But this is where the fun begins: If I use the command that is sent via gmcp as a paladin, it works too, is a DoT and gives the priest line. But it costs only 14 rage... I submitted a bug in game for that.

Looks like GMCP ability information isn't taking class (and Weaponmastery spec) into account when there are multiple abilities with the same name in a skill. If I query for Concuss in Weaponmastery as Dual Cutting, I get the AB file for the Sword and Shield version.

Ziri

Klendathu said:

Could be that the data table is out of date.

Here's the abilities for Runie and Pally, could you validate they're in the correct order?

Runewarden:

1. Collide
2. Bulwark
3. Fragment
4. Onslaught
5. Etch
6. Safeguard

Runie is in the correct order, yep.

But thing is quite out of whack. Not sure if I accidentally did something when I was changing the x,y coordinates on the script, but it's very off.

Using Bulwark sets off the Etch timer
Using Onslaught sets off the Bulwark timer
Using Etch sets off the Onslaught timer

And the timer doesn't just show up over the wrong box, I mean it entirely sets it off. I.E., when Etch timer goes off when I use Bulwark, it shows the entire 45 seconds, and Bulwark goes back to green.

Collide is fine.
Fragment is fine. 
I'm assuming Safeguard is also fine, but as I don't have it yet, I can't check.

I've got absolutely no coding knowledge lol so I don't want to go through and try and find the problem.

Otherwise, beautiful script.

Klendathu

Could you post the trigger line for Bulwark, Onslaught and Etch when you use them, so I can verify my triggers. Also, when you say you set them off, are you manually setting them off, or using another script?

Klendathu

Thanks to @Kyrra I have the triggers, they were calling the wrong abilities from the table, this will be fixed for the next release.

I've also rewritten a portion of the script to make updates easier.

I'm still missing the triggers for the following:

blademaster level 3 (shield breaking)

paladin level 3 (shield breaking)

serpent level 3 (shield breaking)

serpent obviatate

shamen level 3 (shield breaking)

sylvan pierce

Could also do with a priest listing out their abilities and the triggers, my table seems to be a little messed up for that class.

Any help is always appreciated and credited!

Klendathu

UPDATE to 1.3   (Download)

• fixed order of Runewarden abilities (thanks @Kyrraand @Ziri)
• created new function, useAbility, to go off ability name or position in table (thanks Volge)
• added triggers and info for excoriate and obliviate (thanks @Dairon and @Rangor)

Antonius

Can't imagine there's a huge need for Paladin shield break trigger; any Paladin who is burning rage to drop shield is doing it wrong. I can get you the line at some point, but probably won't be until I get back from the US in a couple of weeks.

Deladan

Ok. For everyone using this. It's broke. because of gmcp changes. In the battlerage main script find if gmcp.Char.Status.race == "Dragon" and change it to 

if gmcp.Char.Status.race:find("Dragon") then

Klendathu

Good catch, @Deladan, will have broken a few of my scripts. I'll upload a fixed version soon™.

Klendathu

UPDATE to v1.4 (download)

• Fixed error introduced with change to gmcp for dragon race