[Mudlet] Another denizen targeting script

Ismay

Anyone having battlerage problems? Mine just randomly stopped using battlerage attacks period.

Veldrin

That's because the battlerage skill was renamed into 'Attainment' and the system picks up your skills from the battlerage list which now no longer exists

Sobriquet

I'm not logged in to check, but I assume we just need to change a GMCP setting in the script?

Keneanung

From what I read from the announce, it's not that simple. There are a number of other abilities in the skill now and I have no idea how uniform this is among all the classes.

Klendathu

Shameless plug for my attainment-friendly battlerage tracker, see signature

Keneanung

There's beauty in hard-coding all the things and there is beauty in doing things automatically. I was quicker supporting elementals (except the one server-side bug that's still not fixed), but these changes are structural which broke my way.

Anyways, https://github.com/AchaeaBashingScript/Bashing/releases/download/v1.9-pre-16c8e66-moveBattlerageToAttainment/Bashing.mpackage should fix these issues. If some classes are not fixed, let me know, please.

Vika

Keneanung said:

There's beauty in hard-coding all the things and there is beauty in doing things automatically. I was quicker supporting elementals (except the one server-side bug that's still not fixed), but these changes are structural which broke my way.

Anyways, https://github.com/AchaeaBashingScript/Bashing/releases/download/v1.9-pre-16c8e66-moveBattlerageToAttainment/Bashing.mpackage should fix these issues. If some classes are not fixed, let me know, please.

I really really appreciate such a quick fix! I was just wondering myself why I was sitting at max battlerage and why hunting felt slower.
Much

Sobriquet

The coder support all round in this community is amazing. 

Keneanung

I've been notified of an issue with at least black dragons only using lower damage skills. https://github.com/AchaeaBashingScript/Bashing/releases/download/v1.9-pre-ae01b23-moveBattlerageToAttainment/Bashing.mpackage should fix that.

Veldrin

I fixed the one in my own battlescript by making a list of the non-battlerage abilities and then removing them from the gmcp.Char.Skills.List.list before I use that to populate my battlerage table, then I just had to change my gmcp events from battlerage to Attainment

Keneanung

Veldrin said:

I fixed the one in my own battlescript by making a list of the non-battlerage abilities and then removing them from the gmcp.Char.Skills.List.list before I use that to populate my battlerage table, then I just had to change my gmcp events from battlerage to Attainment

That's probably the way I go if this proves to be too fragile. But for now I'll have a look how my version pans out

Ada

Hi! While the latest update posted by Keneanung correctly picks up battlerage abilities from Attainment, we're having trouble with battlerage skills not getting used due to bugs in IRE's own GMCP data. I've written a set of changes to address it, please find a release here: https://github.com/adayoung/Bashing/releases/tag/1.9-pre-2594940-cooldown2rageAvailable

This is a temporary solution and it'll not be required once IRE over its GMCP issues. Feedback welcome!

Thaisen

Ada said:

Hi! While the latest update posted by Keneanung correctly picks up battlerage abilities from Attainment, we're having trouble with battlerage skills not getting used due to bugs in IRE's own GMCP data. I've written a set of changes to address it, please find a release here: https://github.com/adayoung/Bashing/releases/tag/1.9-pre-2594940-cooldown2rageAvailable

This is a temporary solution and it'll not be required once IRE over its GMCP issues. Feedback welcome!

Thanks for this! Though it still seems that battlerage is not being used at least as a Black Dragon. My acid seems to be used all the time, but then rage just keeps building up and the higher damage skills are never automatically used.

Ada

@Thaisen Can you paste the output of AB ATTAINMENT here, please?

Klendathu

Abilities in Attainment:
-------------------------------------------------------------------------------
Prevail              Assume your primal form.
Portals              Godly Rescue
Dragonspit           Acidic venom causes recurring damage.
Battlerage           The rage of battle.
Dragonsting          Cause sensitivity with a sting of your tail.
Market               Sell, sell, sell!
Battle               Danger awaits!
Limitedportals       Growing independence.
Dissolve             Your breath weapon eats through denizen shields.
Independence         A newbie no more.
Embrace              Full membership in your class.
Tradeskills          Learn a trade.
Theft                Everyone's a target.
Override             Trample your opponent with your massive girth.
Corrode              Annihiliate your opponent's skin with an acidic blast.
Craftsmanship        Learn another trade.
Dragonfear           Terrify your target with an earth-shattering roar.
Multiclass           Learn an additional class.
Sustenance           Sleep is for the weak. Food too.
Dragonhood           The soul of the Greater Dragon.
Polymath             Learn another additional class.
-------------------------------------------------------------------------------
To gain further information on an ability, AB <ability>.

Keneanung

@Veldrin there you have it... I didn't like the feel of the index code and went by your suggestions using a blacklist for skills not to request as rage skills. Hopefully, this makes it more stable as well: https://github.com/AchaeaBashingScript/Bashing/releases/download/v1.9-pre-fae97a7-moveBattlerageToAttainment/Bashing.mpackage

Thaisen

Unfortunately it seems like it still isn’t working. Override is used once at the start of each mudlet session and then never used again. I’ll try to do a little troubleshooting later. Thanks!

Thaisen

From what I can tell it looks like the override skill is being considered on cooldown indefinitely after the first use in the variable 'battlerageSkillsCD', though I'm not sure why it isn't being set back to nil.

Edit: If I manually delete or set the override cooldown to 'false' then it will be used again.

Ada

@Thaisen You should be able to inspect battlerage cooldown with,

lua keneanung.bashing.battlerageSkillsCD

A battlerage going off should appear in that table for cooldown before it's removed by a timer. If you find that table not getting emptied after while, something is very wrong and I need to find you in-game to fix it!

Thaisen

It really seems like the problem is around the setCooldown function. I added a tempTimer to the function and now it works fine, though I don't understand why the timeframe function isn't working for the Override ability specifically.

<div>keneanung.bashing.battlerage.setCooldown = function(rage)
</div><div>	timeframe("keneanung.bashing.battlerageSkillsCD['"..rage.name.."']", 0, rage.cooldown + getNetworkLatency())
</div><div>	tempTimer(rage.cooldown + getNetworkLatency(),&nbsp;
</div><div>		function()
</div><div>			keneanung.bashing.battlerageSkillsCD[rage.name] = false
</div><div>		end
</div><div>	)
</div><div>end
</div>

Ada

Oh, hmm. timeframe may not be available in old versions of Mudlet

Thaisen

Ada said:

Oh, hmm. timeframe may not be available in old versions of Mudlet

We’ll, it worked for dragonspit. Just not for override. Maybe there is a max time allowed?

Ada

Oh, hmm. This may be an oddity but do this,

lua keneanung.bashing.battlerageSkillsCD['abc'] = true

and restore the timeframe in your script.lua file

I know I know strange thing to ask and I don't get it either

Klendathu

Timeframe is wonky, doesn't seem to work for >=20 seconds in Windows. I've been exploring why, but not found a solution.

Vika

Keneanung said:

last post

@Ada

This happens every time a denizen shields, it's disconnected me a few times too. But usually just freezes my mudlet for a few seconds then the burst of spam hits. (I'm a Sylvan, as a side note)

https://ada-young.appspot.com/pastebin/oMDtvYj8

Ada

Vika said:

Keneanung said:

last post

@Ada

This happens every time a denizen shields, it's disconnected me a few times too. But usually just freezes my mudlet for a few seconds then the burst of spam hits. (I'm a Sylvan, as a side note)

https://ada-young.appspot.com/pastebin/oMDtvYj8

Wow, somehow you're a sylvan-apostate! Can you paste the output of 'kconfig bashing' here?

Vika

Ada said:

Vika said:

Keneanung said:

last post

@Ada

This happens every time a denizen shields, it's disconnected me a few times too. But usually just freezes my mudlet for a few seconds then the burst of spam hits. (I'm a Sylvan, as a side note)

https://ada-young.appspot.com/pastebin/oMDtvYj8

Wow, somehow you're a sylvan-apostate! Can you paste the output of 'kconfig bashing' here?

keneanung: Bashing is on

keneanung: Automatic fleeing is on

keneanung: Warning at a security threshhold of 0 health

keneanung: Fleeing at a security threshhold of 100 health

keneanung: Attack is set to kill

keneanung: Autoraze is on

keneanung: Special attack on shielding is set to none

keneanung: Razing shields with rage is on

keneanung: Currently using this battlerage strategy: simple

keneanung: Currently using this system: auto

keneanung: Considering loyals for fallback targets is off

keneanung: Manual targetting is off

keneanung: Waiting for 2 seconds for a new target before stopping, if attacking manutally

keneanung: Loading these additional files on startup:    (Add new file)

keneanung: Version: 1.9-pre-fae97a7-moveBattlerageToAttainment

Ada

You might have the alias KENEANUNGRA set to using a daegger. Check in-game what the output of alias KENEANUNGRA is? Additionally try turning autoraze to 'off' but leave Razing shields with battlerage 'on'.

Keneanung

This sounds familiar, actually. In the past were cases were battlerage abulabili with the same name but of different classes were confused server side and the wrong ability (including the command) was reported back via gmcp. And then the basher tries that wrong command and gets such an error message back.

Ada

Ooops, in that case @Vika you should set the special attack on shielding to the right battlerage command and leave autoraze 'on' Please report your findings!