Welcome to the Achaea Forums! Please be sure to read the Forum Rules.

Long Live Wundersys

2

Comments

  • AntoniusAntonius Posts: 4,374Member @@ - Legendary Achaean
    I have no idea how hard it would be to add into Wundersys because I've not seen the code, but it took me a couple of hours total (though not consecutive) to implement GMCP affliction tracking into my own system, identify the issues with certain afflictions and code work arounds.

    Using GMCP isn't hard and it doesn't take long to code anything to use it once you know what the messages contain, that's kind of the beauty of it.
  • FendoFendo Posts: 49Member ✭✭✭ - Distinguished
    edited August 2016
    WunderSys handles a lot of the affs based on GMCP along with some of the lines to handle things where GMCP was not at the time if I recall correctly.  As well as a whole slew of functions to handle other situations. Take a look  under: 

    Under the Scripts 
    WunderSys Folder
    Curing Folder
    Curing Functions Folder 
    Affliction Functions Script (The other Scripts will detail how other situations are handled)

    Lines 482 to the bottom

    function wsys.gmcpAffAdded()
       local aff,count = string.match( gmcp.Char.Afflictions.Add.name, "(%w+) %((%d+)%)" )
       aff = aff or gmcp.Char.Afflictions.Add.name
       if not exclude[aff] then
          wsys.affadd( aff, nil, nil, true )
       end
    end

    function wsys.gmcpAffRemoved()
       for _,aff in ipairs( gmcp.Char.Afflictions.Remove ) do
          local aff2,count = string.match( aff, "(%w+) %((%d+)%)" )
          aff = aff2 or aff
          if aff_debug then echo("wsys.gmcpAffRemoved:'"..aff.."'") end
          if not exclude[aff] then
             wsys.affcuredconfirm(aff, true)
          end
       end
    end

    registerAnonymousEventHandler("gmcp.Char.Afflictions.Add", "wsys.gmcpAffAdded")
    registerAnonymousEventHandler("gmcp.Char.Afflictions.Remove", "wsys.gmcpAffRemoved")
  • AtalkezAtalkez Posts: 4,496Member, Secret Squirrel @@ - Legendary Achaean
    Doesn't look like that handles the magi burning stuff etc, since they are named oddly.
    Unless the excludeaff thing does that!


    You hug Aurora compassionately.
  • AhmetAhmet Wherever I wanna bePosts: 3,370Member @@ - Legendary Achaean
    Atalkez said:
    Doesn't look like that handles the magi burning stuff etc, since they are named oddly.
    Unless the excludeaff thing does that!
    That's the reason for the string.match bit @Atalkez.
    Huh. Neat.
    Atalkez
  • AesgarAesgar Posts: 428Member ✭✭✭✭ - Eminent
    Can't wait to have Wundersys back. Thanks @Anze
  • InvictusInvictus Posts: 58Member ✭✭ - Stalwart
    Was this ever updated?
    Vokun
  • AnzeAnze Posts: 80Member ✭✭✭ - Distinguished
    It was! Sorry about that. A new release has been drafted and is available at https://github.com/sailgoat/WunderSys/releases
    I encourage all adventurous testers to give it a try and report any old or new issues either here or via GitHub: https://github.com/sailgoat/WunderSys

    As mentioned in the release notes, WBUG has been updated to send a message to myself instead of Tynil. I'm sure I'll regret that at some point but Rome wasn't destroyed in a day.


    CoamenelInvictus
  • CoamenelCoamenel Posts: 188Member ✭✭✭ - Distinguished
    I have made an attempt in adding a few changes specific for woodlore/metamorphosis, but it turns out that github and I have not come to terms yet. I did create a pull request, so it -should- be good.
  • AnzeAnze Posts: 80Member ✭✭✭ - Distinguished
    edited August 2016
    @Coamenel I'm curious as to how you and @Fendo are editing these files. Do you have the WunderSys.xml file installed as a module with sync enabled?

    I created a pull request myself and was able to view the changes I made in-request. With so many changes it makes it a bit more cumbersome to quickly see what's been updated.
  • FendoFendo Posts: 49Member ✭✭✭ - Distinguished
    I am using a clean mudlet profile to do the changes after testing on my mudlet profile. Just need to take out the extras on the new mudlet profile before loading the wundersys package and editing. 
  • CoamenelCoamenel Posts: 188Member ✭✭✭ - Distinguished
    I created an entirely new profile an installed WunderSys.xml as a package. 

    Though it has to be noted that last time I worked an Achaea system, I ported IMTS to Achaea (not nearly as shiny as Vadi did though) and used Zmud as a client! So what I'm saying is that I do not yet "feel" the workings of mudlet. I might contact you when I have an actual keyboard instead of my iphone. 
  • AnzeAnze Posts: 80Member ✭✭✭ - Distinguished
    Please install the xml file as a module instead of a package. You can then enable a sync option which seems to alleviate the over 900,000,000 insertions and deletions issue.
    Coamenel
  • CoamenelCoamenel Posts: 188Member ✭✭✭ - Distinguished
    Anze said:
    Please install the xml file as a module instead of a package. You can then enable a sync option which seems to alleviate the over 900,000,000 insertions and deletions issue.

    I was looking over and over why it did that. I'll install it as a module instead from now on. Thanks for the pointer!
  • AnzeAnze Posts: 80Member ✭✭✭ - Distinguished
    Haven't heard anything nightmarish as of yet -- assuming a few other people have given the new release a spin.

    I have a few things in mind to work on, first of which being a full transition to GMCP afflictions. Beyond that, it's a matter of going through the old issues and seeing which of those are highest priority.

    I am always open to hearing ideas, feature requests or pain points people are having with the system!
  • CoamenelCoamenel Posts: 188Member ✭✭✭ - Distinguished
    Anze said:
    Haven't heard anything nightmarish as of yet -- assuming a few other people have given the new release a spin.

    I have a few things in mind to work on, first of which being a full transition to GMCP afflictions. Beyond that, it's a matter of going through the old issues and seeing which of those are highest priority.

    I am always open to hearing ideas, feature requests or pain points people are having with the system!

    I've not done any combat-ish things with the new release, but I did notice that clot doesn't really seem to work. I'm working on that myself, so I'll push a commit when I've got something to push :)
  • FuscoFusco Posts: 37Member ✭✭ - Stalwart
    Coamenel said:

    I've not done any combat-ish things with the new release, but I did notice that clot doesn't really seem to work. I'm working on that myself, so I'll push a commit when I've got something to push :)
    I had a similar problem. I would set clotting to true, then wshow settings would show it as false, and it wouldn't work. I was looking for the source of the problem and didn't find it, but it started working on its own, so I don't really know how to find the source of the problem.
  • CoamenelCoamenel Posts: 188Member ✭✭✭ - Distinguished
    Fusco said:
    Coamenel said:

    I've not done any combat-ish things with the new release, but I did notice that clot doesn't really seem to work. I'm working on that myself, so I'll push a commit when I've got something to push :)
    I had a similar problem. I would set clotting to true, then wshow settings would show it as false, and it wouldn't work. I was looking for the source of the problem and didn't find it, but it started working on its own, so I don't really know how to find the source of the problem.
    Actually figured it out, I had clot disable on the serverside curing system. I did push a commit that, if you have the clot ability and useclot on in wsys, turns it on. That did help in my case, it's now clotting where necessary.
  • RyzethRyzeth Posts: 1,105Member @ - Epic Achaean
    edited November 2016
    -totes wrong thread-
  • AnzeAnze Posts: 80Member ✭✭✭ - Distinguished
    I will be returning shortly to see how out of date this is. Any assistance would be lovely.
  • AnzeAnze Posts: 80Member ✭✭✭ - Distinguished
    I'm working on integrating CURINGSET currently and am open to any other feature requests. 

    In other news, the original documentation site is down thanks to Dropbox's public folder change. (Don't trust startups with your data, folks.) Was able to get a partial backup from @Jadys and I'll format/update it on the GitHub site shortly.
    KythraAleyah
  • AnzeAnze Posts: 80Member ✭✭✭ - Distinguished
    The repository has been updated to include the missing afflictions that @Sayenna brought to my attention. CURINGSET still needs some work so we don't break anything for existing users.

    The afflictions should show on prompt and via echoes if enabled.

    https://github.com/sailgoat/WunderSys


    DraedethaAtalkez
  • TelinusTelinus Posts: 145Member ✭✭✭ - Distinguished
    Wundersys is still alive?!
  • LyrinLyrin Posts: 145Member ✭✭✭ - Distinguished
    Alive and kicking (ass).
  • MorthifMorthif Posts: 1,501Member @@ - Legendary Achaean
    What else would you use?
  • AntoniusAntonius Posts: 4,374Member @@ - Legendary Achaean
    Morthif said:
    What else would you use?
    Your own system coded to do what you need it to rather than a system generalised to be usable by other people?
    AtalkezCaelan
  • SobriquetSobriquet Posts: 1,874Member @@ - Legendary Achaean
    Antonius said:
    Morthif said:
    What else would you use?
    Your own system coded to do what you need it to rather than a system generalised to be usable by other people?
    The number of people who are capable of coding that can be counted on Pandora's fingers. 
    image
  • AmranuAmranu Posts: 717Member ✭✭✭✭ - Eminent
    There's also little point to coding an entire system for yourself even if you can code. Taking what others have made available and building on it is a far more efficient use of your time.
    Tysandr
  • TysandrTysandr Posts: 342Member ✭✭✭✭ - Eminent
    Until you realise how flimsy it is
    Proof of Concepts: LogrSailing MapTrading
    Simple Nexus things: jqol
    "It's not rocket surgery."

  • AustereAustere TennesseePosts: 2,146Member @@ - Legendary Achaean
    Tysandr said:
    Until you realise how flimsy it is
    Wsys is far from flimsy. A significant portion of "top tier" uses their own modified version.  Thats not to say it's not without issues, but calling it flimsy when it's base has such a firm hold on combat is just silly
  • KythraKythra Posts: 277Member ✭✭✭✭ - Eminent
    I haven't got to touch it yet cuz work but it's awesome to see I can point it towards my newbies again. I coded my own system, so I'm against the views of other people who think it's a waste of time. But I also don't disagree expanding on something like wsys is great. As long as you're learning the ins and outs to coding by doing it you're solid. 

    So the system is updated to recognize things like timeloop and shikudo skills and showing them in prompt and prio swaps?
2
Sign In to Comment.